Disallow indexed reference types in events when using ABIEncoderV2 (backported) #4920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
force-pushed
the
disallow_indexed_ref_v2_for_0_425
branch
from
f864688 to
9c64616
Compare
leonardoalt
reviewed
Sep 6, 2018
| { | ||
| "name": "EventStructWrongData", | ||
| "summary": "Using structs in events logged wrong data.", | ||
| "description": "If a struct is used in an event, the address of the struct is logged instead of the actual data.", |
There was a problem hiding this comment.
It seems like I forgot "indexed" here in the original commit..
There was a problem hiding this comment.
But wasn't that irrelevant? (see #4922 )
There was a problem hiding this comment.
Ah right, this is without ABIEncoderV2.
chriseth
force-pushed
the
disallow_indexed_ref_v2_for_0_425
branch
from
9c64616 to
9902221
Compare
|
Rebased. |
leonardoalt
approved these changes
Sep 6, 2018
chriseth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported version of #4820 with corrected "fixed" date.
Note that this PR merges into "develop_v0425"