Disallow indexed reference types in events when using ABIEncoderV2 #4820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
reviewed
Aug 15, 2018
libsolidity/analysis/TypeChecker.cpp
Outdated
| numIndexed++; | ||
| if ( | ||
| _eventDef.sourceUnit().annotation().experimentalFeatures.count(ExperimentalFeature::ABIEncoderV2) | ||
| && dynamic_cast<ReferenceType const*>(type(*var).get()) |
chriseth
reviewed
Aug 15, 2018
libsolidity/analysis/TypeChecker.cpp
Outdated
| ) | ||
| m_errorReporter.typeError( | ||
| var->location(), | ||
| "Reference types cannot be indexed." |
There was a problem hiding this comment.
Indexed reference types cannot yet be used with ABIEncoderV2
chriseth
suggested changes
Aug 15, 2018
|
Oh and the struct should be taken from storage. |
|
Ah and I think we need an entry in the bug list don't we? |
leonardoalt
force-pushed
the
disallow_indexed_ref_v2
branch
from
337d63a to
d6a8b94
Compare
leonardoalt
force-pushed
the
disallow_indexed_ref_v2
branch
from
d6a8b94 to
c00db3c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4820 +/- ##
===========================================
+ Coverage 87.79% 87.82% +0.03%
===========================================
Files 314 314
Lines 31299 31383 +84
Branches 3702 3702
===========================================
+ Hits 27478 27562 +84
Misses 2561 2561
Partials 1260 1260
|
|
@chriseth Let's merge this without the json path test and I'll create a separate PR for it. |
chriseth
approved these changes
Aug 15, 2018
3 tasks
|
I think this was working for strings, but not for structs. Because the actual hashing is in done in As it turned out in #5102 some tests rely on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4687