clients, simulators/ethereum/rpc: make the RPC test suite work again #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fewer confirmations - use global chainID
Clients should include the tx since it does cover the base fee. Change the test to look for 'failed' status instead.
This fixes running the tests with more than one client.
This only works for HTTP, but should be good enough to find most issues.
fjl
changed the title
This was referenced Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the RPC test suite work again.
Since this test suite requires creating new blocks, I have added support for clique mining in all actively supported clients (geth, besu, nethermind, openethereum). There is a new smoke test for clique mining. The smoke test configures the client for clique and waits for it to create one new, empty block.