Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comprehensive RPC API test suite #230

Closed
FrankSzendzielarz opened this issue Jun 4, 2019 · 7 comments
Closed

Add comprehensive RPC API test suite #230

FrankSzendzielarz opened this issue Jun 4, 2019 · 7 comments
Assignees
Labels

Comments

@FrankSzendzielarz
Copy link
Member

FrankSzendzielarz commented Jun 4, 2019

Check if this is still valid #119

@tkstanczak
Copy link
Contributor

@holiman @fjl will this be added? I would like to talk you about it. I was asked by EF to help arrange the JSON RPC standardization (many have failed before) and from my initial conversations it seems that the test suite will be a hugely important item here.

@fjl
Copy link
Collaborator

fjl commented Jul 29, 2020

We want it very much, been wanting it forever.

@fjl fjl assigned fjl and unassigned FrankSzendzielarz Oct 21, 2020
@fjl
Copy link
Collaborator

fjl commented Oct 21, 2020

I'm working on fixing the existing RPC test suite right now.

@tkstanczak
Copy link
Contributor

@matilote can you check with Felix if you could get this integrated with Nethermind / help with this
@fjl -> I was talking to @matilote and he wanted to work on running this for Nethermind

@fjl
Copy link
Collaborator

fjl commented Oct 21, 2020

The 'running' part is basically taken care of by Hive, the work here is mostly fixing up the RPC simulation to work with the newer Hive simulation API. Quite a few things were broken in the last round of heavy Hive development, I'm basically trying to get it back together right now.

It would be very nice to also fix the other RPC test suite. This one is written in python and was also broken by the Hive API changes made during the big refactoring last year. I don't have time to fix that one though. If @matilote is willing and able, he could pick up that one or rewrite it.

@fjl
Copy link
Collaborator

fjl commented Oct 21, 2020

A warning though: at this time, Hive is still a bit of a mess. It really takes time to figure out how it works, and most documentation is outdated. That's not to say it's impossible to work on, and we would really appreciate help, just need to coordinate.

@fjl
Copy link
Collaborator

fjl commented Jan 12, 2021

The 'ethclient' RPC simulation now works again (as of #418).
We could still add some more tests to it, but the hard part is done.

@tkstanczak The tests found two issues in Nethermind:

I think the first one should be easy to fix. eth_subscribe support is not essential.

@fjl fjl closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants
@fjl @tkstanczak @FrankSzendzielarz and others