core/txpool/legacypool: narrow down the scope of the variable #27471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero5512
requested review from
karalabe,
holiman and
rjl493456442
as code owners
fjl
approved these changes
Jun 15, 2023
fjl
changed the title
|
Please don't merge txpool changes while my PR is open, it will get lost with it. I cannot merge that PR with any changes made in the mean time #27463 |
|
Pls rebase, the txpool package was moved to |
done |
fjl
changed the title
holiman
approved these changes
Jun 19, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…um#27471) Variables discarded, included can be defined closer to their usage. Co-authored-by: Martin Holst Swende <martin@swende.se>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…ethereum#27471)" This reverts commit 8a351f6.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…ethereum#27471)" This reverts commit 8a351f6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
define the discarded, included closer to its usage