all: move main transaction pool into a subpool #27463
Merged
+2,915
−2,089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
requested review from
zsfelfoldi,
rjl493456442,
gballet and
holiman
as code owners
karalabe
force-pushed
the
4844-txpool-subpool
branch
from
0d62361
to
b24bd5f
Compare
karalabe
force-pushed
the
4844-txpool-subpool
branch
from
b24bd5f
to
13b0d09
Compare
This was referenced Jun 15, 2023
holiman
reviewed
Jun 15, 2023
holiman
reviewed
Jun 15, 2023
holiman
reviewed
Jun 15, 2023
holiman
approved these changes
Jun 15, 2023
holiman
reviewed
Jun 16, 2023
14 tasks
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
* all: move main transaction pool into a subpool * go.mod: remove superfluous updates * core/txpool: review fixes, handle txs rejected by all subpools * core/txpool: typos
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 3c12101.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 3c12101.
@karalabe has work on this started yet? And is there a design doc or issue explaining what you meant by this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactor to move the
txpool.TxPoolimplementation tolegacypool.LegacyPool, which will be a sibling to the upcomingblobpool.BlobPool. The integration of the 2 pools will be lightyears simpler if the two are siblings and not parent-child relationship. This abstraction also allows us to move the local txs into their own pool and further simplify the main txpool (legacypool from now on).The reason I named it legacypool instead of something more permanent is because I think we should rethink and reimplement the txpool to use some persistency soon rather than later, so might as well start that idea now.