consensus/clique: add some missing checks #22836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These should be handled commonly between all consensus engines. Are you sure it's needed? |
This is not strictly needed. The state transition ensures that these values are correct, however, that is technically not correct. State transition should not (need to) verify header fields, it should simply assume that headers are correct. In |
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
19 tasks
wanwiset25
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Mar 20, 2024
…d to latest go-eth code
wanwiset25
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Mar 26, 2024
…d to latest go-eth code (#474)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some checks from ethash header verification that were missing on clique.