New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas check when verifying header #83

Closed

minh-bq opened this issue Jul 11, 2022 · 0 comments · Fixed by #80

Contributor

minh-bq commented Jul 11, 2022

In clique, there are some gas checks in headers which is introduced in this PR: ethereum/go-ethereum#22836

The explanation from author in PR

This is not strictly needed. The state transition ensures that these values are correct, however, that is technically not correct.
State transition should not (need to) verify header fields, it should simply assume that headers are correct. In fast, snap and light sync >mode, headerchains are verified without state transition. So we can't have header-checks that are done in state transition only.

This part was later modified to support EIP-1559 in this PR: https://github.com/ethereum/go-ethereum/pull/22837/files#diff-1f9c721fa9815697c0778c180de0f86da1f7c16297d786412e015700a3575362

Do we need to apply this check?

minh-bq mentioned this issue

Fix consortium issues #80

Merged

minh-bq closed this as completed in #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment