Repository navigation
chore(tests): improve EIP-7981 coverage, checklist, and ref-spec pin - #3223
Merged
spencer-tb merged 2 commits intoJul 28, 2026
Merged
spencer-tb merged 2 commits into
spencer-tb merged 2 commits into
Conversation
spencer-tb
marked this pull request as draft
July 23, 2026 14:29
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3223 +/- ##
==================================================
Coverage ? 93.41%
==================================================
Files ? 624
Lines ? 37014
Branches ? 3386
==================================================
Hits ? 34576
Misses ? 1668
Partials ? 770
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
changed the title
spencer-tb
marked this pull request as ready for review
July 24, 2026 10:57
LouisTsai-Csie
approved these changes
Jul 28, 2026
12 tasks done
danceratopz
added a commit
to danceratopz/execution-specs
that referenced
this pull request
Sep 16, 2026
Since ethereum#3223 the pin has been the hash of the EIPs commit that moved the EIP to Review, so the version check never matched a blob. Use the blob hash of eip-7981.md in that same commit. The pinned content is unchanged. Relative to the blob pinned before ethereum#3223 (954963f), the only difference is the status change from Draft to Review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes out EIP-7981 test coverage for the
tests@v21.0.0tracker.Adds fork transition tests pinning the access list intrinsic change (hand-derived EIP-2780/8038/7981 decomposition, balance-pinned) and the validity threshold flip (one address plus two keys is the smallest shape where the EIP-7981 surcharge and EIP-8038 repricing outgrow the EIP-2780 base reduction, so the straddling gas limit is accepted pre-fork and rejected post-fork). Also adds an execution-regime receipt pin (the surcharge is flat, charged on both sides of the gas-used max, per the current spec formulation) and a contract-creation intrinsic boundary test.
Adds
EIPChecklistmarkers plus the not-applicable/external-coverage files, taking the checklist to 100%, repins the reference spec (old pin was dangling), and removes the unusedSpecconstants class (pre-EIP-8038 values).Related Issues or PRs
#1943
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture