-
Notifications
You must be signed in to change notification settings - Fork 415
feat(test-specs): add extra eip-7708 test coverage #2062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(test-specs): add extra eip-7708 test coverage #2062
Conversation
7884a30 to
0457741
Compare
|
|
||
|
|
||
| @pytest.mark.valid_at_transition_to("Amsterdam") | ||
| def test_transfer_log_fork_transition( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should add selfdestruct logs here too.
0457741 to
fca2300
Compare
fca2300 to
6ad08f9
Compare
eedf23b to
26616d9
Compare
8af6e58 to
bf2361b
Compare
26616d9 to
40ad1de
Compare
marioevz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left a comment of a single test that we need to implement eventually.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-7708 #2062 +/- ##
===========================================================
- Coverage 86.14% 83.97% -2.18%
===========================================================
Files 599 642 +43
Lines 39491 42265 +2774
Branches 3782 4064 +282
===========================================================
+ Hits 34021 35493 +1472
- Misses 4848 6055 +1207
- Partials 622 717 +95
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* feat(test-specs): add/refactor tests, add mainnet marked, checklist, coverage check * feat(test-specs): add fork transition test for selfdestruct logs * fix: tests * chore(test-specs): fix fork transition tests * test(test-specs): add code deposit oog test case --------- Co-authored-by: carsons-eels <carson@ethereum.org> Co-authored-by: Mario Vega <marioevz@gmail.com>
* feat(test-specs): add/refactor tests, add mainnet marked, checklist, coverage check * feat(test-specs): add fork transition test for selfdestruct logs * fix: tests * chore(test-specs): fix fork transition tests * test(test-specs): add code deposit oog test case --------- Co-authored-by: carsons-eels <carson@ethereum.org> Co-authored-by: Mario Vega <marioevz@gmail.com>
* feat(test-specs): add/refactor tests, add mainnet marked, checklist, coverage check * feat(test-specs): add fork transition test for selfdestruct logs * fix: tests * chore(test-specs): fix fork transition tests * test(test-specs): add code deposit oog test case --------- Co-authored-by: carsons-eels <carson@ethereum.org> Co-authored-by: Mario Vega <marioevz@gmail.com>
🗒️ Description
Extra test cases for EIP-7708 including a general refactor. Adds all the cases here asked for here: #1875 (comment), including many others.
eip_testing_checklist_template.mdhas been covered and ticked off viaeip_checklist_not_applicable.txt.eip_checklist_external_coverage.txtfor more information.🔗 Related Issues or PRs
Requires #2064 for docs to build as added EIP checklist and coverage items.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.Cute Animal Picture