Skip to content

Conversation

@spencer-tb
Copy link
Contributor

@spencer-tb spencer-tb commented Jan 22, 2026

🗒️ Description

Extra test cases for EIP-7708 including a general refactor. Adds all the cases here asked for here: #1875 (comment), including many others.

  • The eip_testing_checklist_template.md has been covered and ticked off via eip_checklist_not_applicable.txt.
  • EELS coverage is also checked off and verified, see eip_checklist_external_coverage.txt for more information.
  • Mainnet marked tests are included, they need to be verified on the devnet or once a testnet includes Amsterdam changes.

🔗 Related Issues or PRs

Requires #2064 for docs to build as added EIP checklist and coverage items.

✅ Checklist

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->



@pytest.mark.valid_at_transition_to("Amsterdam")
def test_transfer_log_fork_transition(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should add selfdestruct logs here too.

@fselmo fselmo added this to the bal devnet-2 milestone Jan 22, 2026
@fselmo fselmo force-pushed the extra-eip-7708-tests branch from fca2300 to 6ad08f9 Compare January 23, 2026 01:23
@marioevz marioevz force-pushed the eips/amsterdam/eip-7708 branch from 8af6e58 to bf2361b Compare January 23, 2026 04:12
@fselmo fselmo force-pushed the extra-eip-7708-tests branch from 26616d9 to 40ad1de Compare January 23, 2026 04:39
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a comment of a single test that we need to implement eventually.

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.97%. Comparing base (bf16746) to head (e70030f).
⚠️ Report is 12 commits behind head on eips/amsterdam/eip-7708.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           eips/amsterdam/eip-7708    #2062      +/-   ##
===========================================================
- Coverage                    86.14%   83.97%   -2.18%     
===========================================================
  Files                          599      642      +43     
  Lines                        39491    42265    +2774     
  Branches                      3782     4064     +282     
===========================================================
+ Hits                         34021    35493    +1472     
- Misses                        4848     6055    +1207     
- Partials                       622      717      +95     
Flag Coverage Δ
unittests 83.97% <ø> (-2.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spencer-tb spencer-tb merged commit b61ff06 into ethereum:eips/amsterdam/eip-7708 Jan 23, 2026
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 23, 2026
* feat(test-specs): add/refactor tests, add mainnet marked, checklist, coverage check

* feat(test-specs): add fork transition test for selfdestruct logs

* fix: tests

* chore(test-specs): fix fork transition tests

* test(test-specs): add code deposit oog test case

---------

Co-authored-by: carsons-eels <carson@ethereum.org>
Co-authored-by: Mario Vega <marioevz@gmail.com>
github-actions bot pushed a commit that referenced this pull request Jan 26, 2026
* feat(test-specs): add/refactor tests, add mainnet marked, checklist, coverage check

* feat(test-specs): add fork transition test for selfdestruct logs

* fix: tests

* chore(test-specs): fix fork transition tests

* test(test-specs): add code deposit oog test case

---------

Co-authored-by: carsons-eels <carson@ethereum.org>
Co-authored-by: Mario Vega <marioevz@gmail.com>
marioevz added a commit that referenced this pull request Jan 29, 2026
* feat(test-specs): add/refactor tests, add mainnet marked, checklist, coverage check

* feat(test-specs): add fork transition test for selfdestruct logs

* fix: tests

* chore(test-specs): fix fork transition tests

* test(test-specs): add code deposit oog test case

---------

Co-authored-by: carsons-eels <carson@ethereum.org>
Co-authored-by: Mario Vega <marioevz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-specs Area: execution_testing.specs C-test Category: test P-high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants