-
Notifications
You must be signed in to change notification settings - Fork 415
Description
EIP-7708: ETH transfers emit a log
Target Fork: Amsterdam
Complexity Assessment: EIP-7708 Complexity Assessment
Related PRs and Issues
- feat(test-specs): add extra eip-7708 test coverage #2062
- feat(spec-specs): EIP-7708 ETH Transfers Emit a Log #2023
- fix(spec-specs): Move account closure log emission before priority fee charges #2059
- feat(test-tests): add eip-7708 eth transfer log tests and framework support Carsons-Eels/execution-specs#2
- Small update to 7708 EIP requires minor spec update #2088
Instructions
- Assign issue to EIP specification and testing owner(s).
Important
A specifications specialist and a testing specialist should ideally share ownership of the EIP.
- Add the issue to the target fork milestone if applicable (i.e., the EIP is at least in the CFI stage).
Guidance for Marking Items Complete
An item should only be checked off once the EIP is considered stable. In this context, stable means:
- No major issues or ambiguities are still being uncovered in the specification or tests.
- There are no open discussion points awaiting resolution.
- Client implementations have been consistently passing the tests for at least a week.
It is ultimately up to the owners' discretion to decide when an item should be marked as complete, using this guidance as the basis for that decision.
In exceptional cases, an EIP may require changes after some items have been marked complete or even after the entire issue has been completed and closed. This can happen, for example, when significant design optimizations are identified and agreed upon in ACD, or when critical security issues surface and require updates to the specification or tests.
When this occurs, owners should either unmark the relevant checkboxes if the issue is still open, or create a new tracking issue for the modifications if the original issue had already been closed.
Specification + Testing Status
- Testing complexity assessed and documented: EIP-7708.md - 🟢 9.
- Specification implementation merged to
eips/amsterdam/eip-7708(skip if the fork branch merge below is already complete). - Specification updates merged to the corresponding
forks/amsterdambranch. - EIP updates proposed in case of architectural choices surfaced during implementation.
- Required testing framework modifications implemented -> feat(test-tests): add eip-7708 eth transfer log tests and framework support Carsons-Eels/execution-specs#2.
- Test suite implemented -> feat(test-specs): add extra eip-7708 test coverage #2062 and feat(test-tests): add eip-7708 eth transfer log tests and framework support Carsons-Eels/execution-specs#2.
- Full code coverage for all changes -> feat(spec-tests): add eip7778 simple test #2026.
- No regressions or failures in tests from prior forks (including static tests).
- Testing checklist complete -> feat(test-specs): add extra eip-7708 test coverage #2062.
- Hardening session completed.
- Benchmarking tests written and results documented -> N/A.
- Ran tests using
executeto ensure compatibility, and marked specific tests to be skipped when they cannot be executed on live networks. - Added Mainnet-marked tests (example test) -> feat(test-specs): add extra eip-7708 test coverage #2062.
Process Status
- Hive tests passing on at least two implementations.
- EIP included in a devnet.