UI migrate CardList
#7721
Merged
UI migrate CardList
#7721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettinarip
requested review from
corwintines,
jmcook1186,
minimalsm,
samajammin and
wackerow
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pettinarip
commented
Sep 6, 2022
| )} | ||
| </ItemLink> | ||
| return isLink ? ( | ||
| <LinkBox key={id || idx}> |
There was a problem hiding this comment.
More about LinkOverlay and LinkBox here: https://chakra-ui.com/docs/components/link-overlay/usage
Good for a11y.
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 37m |
This was referenced Sep 24, 2022
This was referenced Sep 28, 2022
corwintines
approved these changes
Oct 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate
CardListcomponent to Chakra.It also includes a refactor on the URL util functions that used to live inside the
Linkcomponent. I've moved all of those related functions to its own file (src/utils/url.ts).Related Issue
#6374