Use skips instead of asserting when an SSZ test is cancelled#4578
Merged
jtraglia merged 1 commit intoethereum:masterfrom Sep 11, 2025
Merged
Use skips instead of asserting when an SSZ test is cancelled#4578jtraglia merged 1 commit intoethereum:masterfrom
jtraglia merged 1 commit intoethereum:masterfrom
Conversation
SSZ tests are scheduled asynchronously since ethereum#4574, but those that are later determined to be inapplicable should be properly cancelled by raising SkippedTest instead of aborting test generation. Notably, this is about tests where a valid object is serialized, the serialized data is subsequently modified and parsed again. As the modified data may still be valid depending on the structure, such tests have to be skipped as they do not denote invalid data.
jtraglia
approved these changes
Sep 11, 2025
Member
jtraglia
left a comment
jtraglia
left a comment
There was a problem hiding this comment.
Thanks @etan-status. To be clear, a mutation does not guarantee that the data is invalid. Skipping these is correct.
Member
|
Can confirm these all pass. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSZ tests are scheduled asynchronously since #4574, but those that are later determined to be inapplicable should be properly cancelled by raising SkippedTest instead of aborting test generation.
Notably, this is about tests where a valid object is serialized, the serialized data is subsequently modified and parsed again. As the modified data may still be valid depending on the structure, such tests have to be skipped as they do not denote invalid data.