Speed up test generation bootstrap#4574
Merged
jtraglia merged 1 commit intoethereum:masterfrom Sep 10, 2025
Merged
Conversation
jtraglia
approved these changes
Sep 10, 2025
Member
jtraglia
left a comment
jtraglia
left a comment
There was a problem hiding this comment.
Nice, thank you for finding/fixing this!
etan-status
reviewed
Sep 11, 2025
| _ = deserialize(typ, serialized) | ||
| except Exception: | ||
| return serialized | ||
| assert False # should throw |
Contributor
There was a problem hiding this comment.
Not necessarily, it's not guaranteed that the modification triggers an exception in all circumstances.
Contributor
There was a problem hiding this comment.
i.e., if it would be statically known that it triggers an exception, the entire check is pointless.
Member
There was a problem hiding this comment.
Pretty sure this is why reference test generation is failing now too.
https://github.com/ethereum/consensus-specs/actions/runs/17632183499
@leolara did you test this before making the PR?
Member
There was a problem hiding this comment.
I would prefer a separate/small PR with just that fix.
etan-status
added a commit
to etan-status/consensus-specs
that referenced
this pull request
Sep 11, 2025
SSZ tests are scheduled asynchronously since ethereum#4574, but those that are later determined to be inapplicable should be properly cancelled by raising SkippedTest instead of aborting test generation. Notably, this is about tests where a valid object is serialized, the serialized data is subsequently modified and parsed again. As the modified data may still be valid depending on the structure, such tests have to be skipped as they do not denote invalid data.
jtraglia
pushed a commit
that referenced
this pull request
Sep 11, 2025
SSZ tests are scheduled asynchronously since #4574, but those that are later determined to be inapplicable should be properly cancelled by raising SkippedTest instead of aborting test generation. Notably, this is about tests where a valid object is serialized, the serialized data is subsequently modified and parsed again. As the modified data may still be valid depending on the structure, such tests have to be skipped as they do not denote invalid data.
etan-status
added a commit
to etan-status/consensus-specs
that referenced
this pull request
Oct 7, 2025
With ethereum#4574, the same RNG instance was captured by the various `the_test` functions. When they were subsequently executed in parallel, this led to non-deterministic tests. However, ethereum#4639 prefers reproducible tests. Instead of running tests in parallel on a shared RNG instance, the RNG instance is now used during the single-threaded test collection stage to produce a deterministic order of seeds, which is then used to create a per-test RNG instance that is not shared with any other tests, hence not being subject to non-determinism from parallel execution.
jtraglia
pushed a commit
that referenced
this pull request
Oct 7, 2025
With #4574, the same RNG instance was captured by the various `the_test` functions. When they were subsequently executed in parallel, this led to non-deterministic tests. However, #4639 prefers reproducible tests. Instead of running tests in parallel on a shared RNG instance, the RNG instance is now used during the single-threaded test collection stage to produce a deterministic order of seeds, which is then used to create a per-test RNG instance that is not shared with any other tests, hence not being subject to non-determinism from parallel execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By making the test run at test time instead of collection time in SSZ generic container.
This was first introduced here: https://github.com/ethereum/consensus-specs/pull/4541/files but that PR has more complications with other things