Skip to content

Comments

Fix some testgen issues related to computed constants#4157

Merged
jtraglia merged 6 commits intoethereum:devfrom
jtraglia:fix-test-gen
Mar 10, 2025
Merged

Fix some testgen issues related to computed constants#4157
jtraglia merged 6 commits intoethereum:devfrom
jtraglia:fix-test-gen

Conversation

@jtraglia
Copy link
Member

This PR fixes some small side effects of this change:

This the error log here:

Notably:

  File "/opt/actions-runner/_work/consensus-specs/consensus-specs/consensus-specs/venv/lib/python3.12/site-packages/eth2spec/eip7732/mainnet.py", line 348, in <module>
    PAYLOAD_TIMELY_THRESHOLD = PTC_SIZE / 2
                               ~~~~~~~~~^~~
  File "/opt/actions-runner/_work/consensus-specs/consensus-specs/consensus-specs/venv/lib/python3.12/site-packages/remerkleable/basic.py", line 120, in __truediv__
    raise OperationNotSupported(f"non-integer division '{self} / {other}' "
remerkleable.basic.OperationNotSupported: non-integer division '512 / 2' is not valid for uint64 left hand type

and

  File "/opt/actions-runner/_work/consensus-specs/consensus-specs/consensus-specs/venv/lib/python3.12/site-packages/ruamel/yaml/representer.py", line 354, in represent_undefined
    raise RepresenterError(_F('cannot represent an object: {data!s}', data=data))
ruamel.yaml.representer.RepresenterError: cannot represent an object: 127

@jtraglia jtraglia merged commit 2cc2cd9 into ethereum:dev Mar 10, 2025
21 of 23 checks passed
@jtraglia jtraglia deleted the fix-test-gen branch March 10, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant