Simplify build system for computed constants#4152
Merged
jtraglia merged 2 commits intoethereum:devfrom Mar 9, 2025
Merged
Conversation
When type definitions depend on preset values, those preset values have to be manually specified in `hardcoded_custom_type_dep_constants` in a manual and error prone way. By using heuristics similar to other parts of the spec builder, that can be automated so that computed constants are automatically generated _after_ preset values are emitted. This also makes it clearer which constants are pure, and which constants depend on specific preset values being used.
Contributor
Author
|
The diff in |
jtraglia
reviewed
Mar 8, 2025
jtraglia
approved these changes
Mar 9, 2025
Member
jtraglia
left a comment
jtraglia
left a comment
There was a problem hiding this comment.
This was a great idea. Thanks @etan-status!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When type definitions depend on preset values, those preset values have to be manually specified in
hardcoded_custom_type_dep_constantsin a manual and error prone way. By using heuristics similar to other parts of the spec builder, that can be automated so that computed constants are automatically generated after preset values are emitted. This also makes it clearer which constants are pure, and which constants depend on specific preset values being used.