You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments regarding clarification, plus have linked my thoughts on the current idea of changes to the engine API and a disagreement on how to construct ILs 😄 👍
Some minor comments regarding clarification, plus have linked my thoughts on the current idea of changes to the engine API and a disagreement on how to construct ILs 😄 👍
Thanks for feedback! Just to be clear, this PR is just to add the IL building stuff. Most of these comments apply to the original PR it's built on so will make any changes there that aren't related to IL building
Some minor comments regarding clarification, plus have linked my thoughts on the current idea of changes to the engine API and a disagreement on how to construct ILs 😄 👍
Thanks for feedback! Just to be clear, this PR is just to add the IL building stuff. Most of these comments apply to the original PR it's built on so will make any changes there that aren't related to IL building
Ah ok! You could (for the diff) also point the original PR to only present the relevant diff here and not the changes of the OG PR also 😄 👍
Some minor comments regarding clarification, plus have linked my thoughts on the current idea of changes to the engine API and a disagreement on how to construct ILs 😄 👍
Thanks for feedback! Just to be clear, this PR is just to add the IL building stuff. Most of these comments apply to the original PR it's built on so will make any changes there that aren't related to IL building
Ah ok! You could (for the diff) also point the original PR to only present the relevant diff here and not the changes of the OG PR also 😄 👍
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
c-update
Suggests building IL using nondeterminism and bias, explained here