-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-7805: expand on EL changes #9381
base: master
Are you sure you want to change the base?
Conversation
Marchhill
commented
Feb 19, 2025
- Add Engine API changes from Add initial FOCIL spec execution-apis#609
- Specify IL building process
- Clarify some details of EL / engine API changes
File
|
EIPS/eip-7805.md
Outdated
|
||
#### IL Building | ||
|
||
The IL should be built using the following rules: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we don't impose IL ordering rules. Some clients may prefer to pick transactions based on priority fee while others may choose different heuristic algorithms. We expect more diverse approaches on IL construction would foster censorship resistance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, I moved the previous section on IL building to here and added a bit about it being optional. This section seems like a more suitable place for it
Co-authored-by: JihoonSong <jihoonsong@users.noreply.github.com>
The commit 1bb8e94 (as a parent of b169cb8) contains errors. |
|
||
#### IL Building | ||
|
||
By default, ILs are built by selecting raw transactions from the public mempool, ordered by priority fees, up to the IL’s maximum size in bytes of `MAX_BYTES_PER_INCLUSION_LIST = 8 KiB` per IL. Additional rules can be optionally applied to maximize censorship resistance, such as prioritizing valid transactions that have been pending in the mempool the longest. Implementations are free to choose their own ordering rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no default rule. While ordering and selecting transactions by priority fee is probably the most anticipated strategy, it should remain as optional, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was moved from elsewhere in the EIP but maybe should be changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did you get it from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding adding this to the EIP, I want to ask other people's opinions. cc @soispoke @terencechain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previously it was here: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7805.md#il-committee-members
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right, my bad. I prefer to keep it as is and have only engine API changes. I think that gives us better readability.