Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify EIP 4 author #855

Merged
merged 3 commits into from
Jan 27, 2018
Merged

clarify EIP 4 author #855

merged 3 commits into from
Jan 27, 2018

Conversation

cdetrio
Copy link
Member

@cdetrio cdetrio commented Jan 26, 2018

Clarify authorship and reformat to markdown.

pirapira
pirapira previously requested changes Jan 26, 2018
View reviewed changes
Copy link
Member

@pirapira pirapira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot clearly see this in git log (yes, he has one commit, but that one changes one character only).

@wanderer are you the author of this EIP?

@cdetrio
Copy link
Member Author

cdetrio commented Jan 26, 2018

Thanks for double checking. I tracked down the git history and @ethers was the author #17

@cdetrio
Copy link
Member Author

cdetrio commented Jan 26, 2018 •
edited
Loading

It is standard to change the author for this kind of derivative work (in this case, derived from BIP 123). For example REP 1, JEP 1, BEP 1 are all derived from PEP 1 but have changed the author. The original author of the preexisting work should be given attribution, but the author should be the person who actually submitted the EIP.

axic
axic reviewed Jan 26, 2018
View reviewed changes
EIPs/eip-4.md Outdated

This document describes a classification scheme for EIPs, adapted from BIP123.
This document describes a classification scheme for EIPs, adapted from BIP123 by Eric Lombrozo.
Copy link
Member

@axic axic Jan 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this now read as BIP123 was adapted to EIP4 by Eric Lombrozo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, will just reference with an inline link, thanks.

@nicksavers nicksavers dismissed pirapira’s stale review January 27, 2018 22:28

Author has been clarified.

@nicksavers nicksavers merged commit 8c8dc2f into ethereum:master Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic left review comments

@nicksavers nicksavers nicksavers approved these changes

@pirapira pirapira pirapira left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cdetrio @axic @pirapira @nicksavers