Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classify Standard EIPs - adapted from BIP123 #17

Merged
merged 4 commits into from
Nov 22, 2015

Conversation

ethers
Copy link
Member

@ethers ethers commented Nov 17, 2015

No description provided.

@wanderer
Copy link
Member

needs to be cleaned up a bit. It still mentions Bitcoin. And Networking is already specified to track seperatly in EIP-1

@ethers
Copy link
Member Author

ethers commented Nov 18, 2015

thanks for the feedback. Before this EIP, I did see EIP-1 did mention Networking separately. But it didn't seem as clean as BIP123. So it sounds like there's 2 approaches. We either remove the "Peer Services" in this EIP, or remove Networking in EIP-1 and let this EIP manage it/Networking under "Peer Services".
Which would you prefer?

@wanderer
Copy link
Member

ok lets change "Peer Services" to "Networking". Core networking; things that affect RLPx will continue to track separately. But things like eth wire protocol changes would fit nicely here. Lastly what do you think about adding another category for standardizing contracts? This would take care of things like #20 and #22

@ethers ethers changed the title EIP3 adapted from BIP123 classify Standard EIPs - adapted from BIP123 Nov 21, 2015
@ethers
Copy link
Member Author

ethers commented Nov 21, 2015

done changed to Networking.
At this stage, I think it's early to sub-categorize Informational EIPs. But I'll open it up for discussion separately, since this is classifying Standard EIPs.

wanderer added a commit that referenced this pull request Nov 22, 2015
classify Standard EIPs - adapted from BIP123
@wanderer wanderer merged commit febb17b into ethereum:master Nov 22, 2015
@cdetrio cdetrio mentioned this pull request Jan 26, 2018
tbergmueller added a commit to authenticvision/ethereum-eips that referenced this pull request May 17, 2023
According to SamWilsn in Editor Office Hours ethereum#17, functions that are
only called by the contract maintainer must not be part of the
Interfaces. Hence removing them
tbergmueller added a commit to authenticvision/ethereum-eips that referenced this pull request May 17, 2023
According to SamWilsn in Editor Office Hours ethereum#17, functions that are
only called by the contract maintainer must not be part of the
Interfaces. Hence removing them
tbergmueller added a commit to authenticvision/ethereum-eips that referenced this pull request May 17, 2023
According to SamWilsn in Editor Office Hours ethereum#17, functions that are
only called by the contract maintainer must not be part of the
Interfaces. Hence removing them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants