Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-node/rollup/derive: also mark IsLast as true when closed && maxDataSize==readyBytes #9696

Merged
merged 4 commits into from
Mar 1, 2024
Merged

op-node/rollup/derive: also mark IsLast as true when closed && maxDataSize==readyBytes #9696

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3452cca
also mark IsLast as true when maxDataSize==readyBytes
zhiqiangxu Feb 29, 2024
daca503
add TestOutputFrameNoEmptyLastFrame
zhiqiangxu Feb 29, 2024
5c0a764
fix typo
zhiqiangxu Feb 29, 2024
0670414
fix for review
zhiqiangxu Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion op-node/rollup/derive/channel_out.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ func createEmptyFrame(id ChannelID, frame uint64, readyBytes int, closed bool, m

// Copy data from the local buffer into the frame data buffer
maxDataSize := maxSize - FrameV0OverHeadSize
if maxDataSize > uint64(readyBytes) {
if maxDataSize >= uint64(readyBytes) {
maxDataSize = uint64(readyBytes)
// If we are closed & will not spill past the current frame
// mark it is the final frame of the channel.
zhiqiangxu marked this conversation as resolved.
Show resolved Hide resolved
Expand Down