-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-node/rollup/derive: also mark IsLast
as true
when closed && maxDataSize==readyBytes
#9696
op-node/rollup/derive: also mark IsLast
as true
when closed && maxDataSize==readyBytes
#9696
Conversation
WalkthroughWalkthroughThe changes involve ensuring that the maximum data size is correctly set in two different contexts when it is greater than or equal to a given number, rather than just greater. Additionally, a new test has been added to verify the behavior of output frame generation when the last frame is not empty. These modifications improve accuracy and clarity in handling data sizes and enhance testing for output frame generation. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
IsLast
as true
when maxDataSize==readyBytes
IsLast
as true
when closed && maxDataSize==readyBytes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test that demonstrates why this is need please?
Done. |
a5b423b
to
a1cf1f0
Compare
a1cf1f0
to
5c0a764
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
IsLast
as true
when closed && maxDataSize==readyBytes
IsLast
as true
when closed && maxDataSize==readyBytes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice catch.
I checked our local logs and we didn't hit that case on mainnet over the last 30 days, which would have been a channel with 2 frames in the op-node logs, but only one frame in op-batcher logs. Still worth fixing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
cd3f554
Otherwise there may be an empty frame of size 0 which is marked last.