Conversation
Contributor
WalkthroughWalkthroughThe Changes
Recent Review DetailsConfiguration used: .coderabbit.yml Files selected for processing (1)
Files skipped from review due to trivial changes (1)
Additional Context UsedLearnings (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10572 +/- ##
============================================
- Coverage 42.36% 29.22% -13.15%
============================================
Files 73 31 -42
Lines 4836 2898 -1938
Branches 766 614 -152
============================================
- Hits 2049 847 -1202
+ Misses 2680 1976 -704
+ Partials 107 75 -32
Flags with carried forward coverage won't be shown. Click here to find out more. |
tynes
approved these changes
May 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rdovgan
pushed a commit
to rdovgan/optimism
that referenced
this pull request
Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OptimismPortal2 proofs still might be too resource intensive for these runners—in the below screenshot I ran all proofs locally and you can see the OptimismPortal2 proofs are much slower than OptimismPortal1. I'm going to run proofs overnight again with a different config to get some insight into the performance difference. In the meantime this PR changes CI to only run OptimismPortal proofs to avoid the infrastructure fail errors. cc @clabby