ci: reduce kontrol tests

[mds1]

#10429 added Kontrol proofs for OptimismPortal2. However, proofs use a lot of RAM and we now exceed the 32GB memory limit on xlarge runners, causing the "Infrastructure Fail. This job appears to have stopped responding, try re-running it" failures.

Soon, RV will open a PR to offload proof execution to them which will run all proofs to mitigate this. For now, we remove 2 more proofs from CI to attempt to get back below the resource usage limit.

[coderabbitai]

Walkthrough

Walkthrough

The recent updates to the run-kontrol.sh script focus on modifying the test cases related to withdrawal transactions within the OptimismPortalKontrol and OptimismPortal2Kontrol classes. Specifically, certain test cases were commented out, while a new test case for OptimismPortal2Kontrol was added.

Changes

File Path	Change Summary
.../contracts-bedrock/test/kontrol/scripts/run-kontrol.sh	Commented out OptimismPortalKontrol.prove_proveWithdrawalTransaction_paused0 and OptimismPortal2Kontrol.prove_proveWithdrawalTransaction_paused1. Added OptimismPortal2Kontrol.prove_proveWithdrawalTransaction_paused0 to the test list.

---

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fa88d9c and 2be02c2.

Files selected for processing (1)

• packages/contracts-bedrock/test/kontrol/scripts/run-kontrol.sh (2 hunks)

Additional Context Used

Learnings (2)

Common

User: JuanCoRo
PR: ethereum-optimism/optimism#10292
File: packages/contracts-bedrock/test/kontrol/scripts/run-kontrol.sh:128-128
Timestamp: 2024-04-24T18:15:27.717Z
Learning: User JuanCoRo introduced an extra parenthesis in the test name `OptimismPortalKontrol.prove_proveWithdrawalTransaction_paused1(` to avoid matching with `OptimismPortalKontrol.prove_proveWithdrawalTransaction_paused10` in the `run-kontrol.sh` script as part of PR #10292. This is a workaround to handle test selection based on naming conventions.

User: JuanCoRo
PR: ethereum-optimism/optimism#10292
File: packages/contracts-bedrock/test/kontrol/scripts/run-kontrol.sh:128-128
Timestamp: 2024-04-24T18:19:24.451Z
Learning: User JuanCoRo confirmed that the extra parenthesis in the test name `OptimismPortalKontrol.prove_proveWithdrawalTransaction_paused1(` does not introduce syntax errors and functions as intended in the `run-kontrol.sh` script as part of PR #10292. This was verified through local testing.

packages/contracts-bedrock/test/kontrol/scripts/run-kontrol.sh (2)

User: JuanCoRo
PR: ethereum-optimism/optimism#10292
File: packages/contracts-bedrock/test/kontrol/scripts/run-kontrol.sh:128-128
Timestamp: 2024-04-24T18:15:27.717Z
Learning: User JuanCoRo introduced an extra parenthesis in the test name `OptimismPortalKontrol.prove_proveWithdrawalTransaction_paused1(` to avoid matching with `OptimismPortalKontrol.prove_proveWithdrawalTransaction_paused10` in the `run-kontrol.sh` script as part of PR #10292. This is a workaround to handle test selection based on naming conventions.

User: JuanCoRo
PR: ethereum-optimism/optimism#10292
File: packages/contracts-bedrock/test/kontrol/scripts/run-kontrol.sh:128-128
Timestamp: 2024-04-24T18:19:24.451Z
Learning: User JuanCoRo confirmed that the extra parenthesis in the test name `OptimismPortalKontrol.prove_proveWithdrawalTransaction_paused1(` does not introduce syntax errors and functions as intended in the `run-kontrol.sh` script as part of PR #10292. This was verified through local testing.

Additional comments not posted (4)

packages/contracts-bedrock/test/kontrol/scripts/run-kontrol.sh (4)

113-113: Commenting out the test case OptimismPortalKontrol.prove_proveWithdrawalTransaction_paused0 is consistent with the PR objective to reduce memory usage. Ensure that this change does not affect critical test coverage.

---

124-125: Commenting out the test case OptimismPortal2Kontrol.prove_proveWithdrawalTransaction_paused0 is consistent with the PR objective to reduce memory usage. Ensure that this change does not affect critical test coverage.

---

126-126: Commenting out the test case OptimismPortal2Kontrol.prove_proveWithdrawalTransaction_paused1 is consistent with the PR objective to reduce memory usage. Ensure that this change does not affect critical test coverage.

---

134-134: Adding the test case OptimismPortal2Kontrol.prove_proveWithdrawalTransaction_paused0 to the test list is consistent with the PR objective. Ensure that this test case is correctly implemented and does not introduce any syntax errors.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.22%. Comparing base (fa88d9c) to head (2be02c2).
Report is 11 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #10563       +/-   ##
============================================
- Coverage    42.36%   29.22%   -13.15%     
============================================
  Files           73       31       -42     
  Lines         4836     2898     -1938     
  Branches       766      614      -152     
============================================
- Hits          2049      847     -1202     
+ Misses        2680     1976      -704     
+ Partials       107       75       -32     

Flag	Coverage Δ
cannon-go-tests	?
chain-mon-tests	27.14% <ø> (ø)
common-ts-tests	?
contracts-ts-tests	12.25% <ø> (ø)
core-utils-tests	?
sdk-tests	40.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 42 files with indirect coverage changes

[semgrep-app]

Semgrep found 3 golang_fmt_errorf_no_params findings:

• op-node/rollup/types.go
  • L416 - Triage
  • L419 - Triage
  • L422 - Triage

No fmt.Errorf invocations without fmt arguments allowed

_{Ignore this finding from golang_fmt_errorf_no_params.}

Semgrep found 1 todos_require_linear finding:

• op-node/rollup/derive/plasma_data_source.go
  • L71 - Triage

Please create a GitHub ticket for this TODO.

_{Ignore this finding from todos_require_linear.}

[maurelian]

one question.