Merge pull request #46 from izziaraffaele/master

Use Signer instead of BaseWallet in signOffchainAttestation()
ethereum-attestation-service · Aug 11, 2023 · 0ec0e35 · 0ec0e35
2 parents c69a144 + 8a31db4
commit 0ec0e35
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 21 deletions.
diff --git a/dist/offchain/offchain.d.ts b/dist/offchain/offchain.d.ts
@@ -1,4 +1,4 @@
-import { BaseWallet } from 'ethers';
+import { Signer } from 'ethers';
 import { DomainTypedData, EIP712MessageTypes, EIP712Params, EIP712Response, PartialTypedDataConfig, TypedData, TypedDataHandler } from './typed-data-handler';
 export { EIP712Request, PartialTypedDataConfig, EIP712MessageTypes } from './typed-data-handler';
 interface OffchainAttestationType {
@@ -27,7 +27,7 @@ export declare class Offchain extends TypedDataHandler {
     constructor(config: PartialTypedDataConfig, version: number);
     getDomainSeparator(): string;
     getDomainTypedData(): DomainTypedData;
-    signOffchainAttestation(params: OffchainAttestationParams, signer: BaseWallet): Promise<SignedOffchainAttestation>;
+    signOffchainAttestation(params: OffchainAttestationParams, signer: Signer): Promise<SignedOffchainAttestation>;
     verifyOffchainAttestationSignature(attester: string, request: SignedOffchainAttestation): boolean;
     static getOffchainUID(params: OffchainAttestationParams): string;
 }
diff --git a/dist/offchain/offchain.js.map b/dist/offchain/offchain.js.map
diff --git a/dist/offchain/typed-data-handler.d.ts b/dist/offchain/typed-data-handler.d.ts
@@ -1,4 +1,4 @@
-import { BaseWallet } from 'ethers';
+import { Signer } from 'ethers';
 export interface PartialTypedDataConfig {
     address: string;
     version: string;
@@ -54,6 +54,6 @@ export declare abstract class TypedDataHandler {
     constructor(config: TypedDataConfig);
     getDomainSeparator(): string;
     getDomainTypedData(): DomainTypedData;
-    signTypedDataRequest<T extends EIP712MessageTypes, P extends EIP712Params>(params: P, types: EIP712TypedData<T, P>, signer: BaseWallet): Promise<EIP712Response<T, P>>;
+    signTypedDataRequest<T extends EIP712MessageTypes, P extends EIP712Params>(params: P, types: EIP712TypedData<T, P>, signer: Signer): Promise<EIP712Response<T, P>>;
     verifyTypedDataRequestSignature<T extends EIP712MessageTypes, P extends EIP712Params>(attester: string, request: EIP712Response<T, P>): boolean;
 }
diff --git a/dist/offchain/typed-data-handler.js.map b/dist/offchain/typed-data-handler.js.map
diff --git a/src/offchain/offchain.ts b/src/offchain/offchain.ts
@@ -1,4 +1,4 @@
-import { AbiCoder, BaseWallet, keccak256, toUtf8Bytes } from 'ethers';
+import { AbiCoder, Signer, keccak256, toUtf8Bytes } from 'ethers';
 import { getOffchainUID } from '../utils';
 import { EIP712_NAME } from './delegated';
 import {
@@ -107,7 +107,7 @@ export class Offchain extends TypedDataHandler {
 
   public async signOffchainAttestation(
     params: OffchainAttestationParams,
-    signer: BaseWallet
+    signer: Signer
   ): Promise<SignedOffchainAttestation> {
     const uid = Offchain.getOffchainUID(params);
 

diff --git a/src/offchain/typed-data-handler.ts b/src/offchain/typed-data-handler.ts
@@ -1,6 +1,6 @@
 import {
   AbiCoder,
-  BaseWallet,
+  Signer,
   getAddress,
   hexlify,
   keccak256,
@@ -35,17 +35,17 @@ export interface TypedDataParams {
 export interface TypedData {
   name: string;
   type:
-    | 'bool'
-    | 'uint8'
-    | 'uint16'
-    | 'uint32'
-    | 'uint64'
-    | 'uint128'
-    | 'uint256'
-    | 'address'
-    | 'string'
-    | 'bytes'
-    | 'bytes32';
+  | 'bool'
+  | 'uint8'
+  | 'uint16'
+  | 'uint32'
+  | 'uint64'
+  | 'uint128'
+  | 'uint256'
+  | 'address'
+  | 'string'
+  | 'bytes'
+  | 'bytes32';
 }
 
 export interface EIP712DomainTypedData {
@@ -118,7 +118,7 @@ export abstract class TypedDataHandler {
   public async signTypedDataRequest<T extends EIP712MessageTypes, P extends EIP712Params>(
     params: P,
     types: EIP712TypedData<T, P>,
-    signer: BaseWallet
+    signer: Signer
   ): Promise<EIP712Response<T, P>> {
     const rawSignature = await signer.signTypedData(types.domain, types.types, params);
     const signature = Sig.from(rawSignature);