Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more powerful drift windowing strategies, warmup and dynamic thresholds #564

Merged
merged 23 commits into from
Aug 14, 2024

Small fix wrt interval tests

9594453
Select commit
Loading
Failed to load commit list.
Merged

feat: Add more powerful drift windowing strategies, warmup and dynamic thresholds #564

Small fix wrt interval tests
9594453
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 14, 2024 in 1s

84.86% (-0.01%) compared to 3de6590

View this Pull Request on Codecov

84.86% (-0.01%) compared to 3de6590

Details

Codecov Report

Attention: Patch coverage is 87.82895% with 37 lines in your changes missing coverage. Please review.

Project coverage is 84.86%. Comparing base (3de6590) to head (9594453).

Files Patch % Lines
.../internal/triggers/drift/detection_window/time_.py 50.00% 18 Missing ⚠️
...n/supervisor/internal/triggers/datadrifttrigger.py 86.36% 12 Missing ⚠️
...internal/triggers/drift/detection_window/amount.py 90.00% 3 Missing ⚠️
modyn/supervisor/internal/triggers/utils/utils.py 66.66% 2 Missing ⚠️
...dyn/config/schema/pipeline/trigger/drift/config.py 91.66% 1 Missing ⚠️
...pervisor/internal/triggers/drift/detector/alibi.py 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
- Coverage   84.87%   84.86%   -0.01%     
==========================================
  Files         224      233       +9     
  Lines       10300    10480     +180     
==========================================
+ Hits         8742     8894     +152     
- Misses       1558     1586      +28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov