Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more powerful drift windowing strategies, warmup and dynamic thresholds #564

Merged
merged 23 commits into from
Aug 14, 2024

Small fix wrt interval tests

9594453
Select commit
Loading
Failed to load commit list.
Merged

feat: Add more powerful drift windowing strategies, warmup and dynamic thresholds #564

Small fix wrt interval tests
9594453
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Aug 14, 2024 in 0s

87.82% of diff hit (target 84.87%)

View this Pull Request on Codecov

87.82% of diff hit (target 84.87%)

Annotations

Check warning on line 75 in modyn/config/schema/pipeline/trigger/drift/config.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/config/schema/pipeline/trigger/drift/config.py#L75 

Added line #L75 was not covered by tests

Check warning on line 208 in modyn/supervisor/internal/triggers/datadrifttrigger.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/datadrifttrigger.py#L208 

Added line #L208 was not covered by tests

Check warning on line 221 in modyn/supervisor/internal/triggers/datadrifttrigger.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/datadrifttrigger.py#L221 

Added line #L221 was not covered by tests

Check warning on line 272 in modyn/supervisor/internal/triggers/datadrifttrigger.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/datadrifttrigger.py#L272 

Added line #L272 was not covered by tests

Check warning on line 299 in modyn/supervisor/internal/triggers/datadrifttrigger.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/datadrifttrigger.py#L298-L299 

Added lines #L298 - L299 were not covered by tests

Check warning on line 305 in modyn/supervisor/internal/triggers/datadrifttrigger.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/datadrifttrigger.py#L305 

Added line #L305 was not covered by tests

Check warning on line 330 in modyn/supervisor/internal/triggers/datadrifttrigger.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/datadrifttrigger.py#L330 

Added line #L330 was not covered by tests

Check warning on line 332 in modyn/supervisor/internal/triggers/datadrifttrigger.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/datadrifttrigger.py#L332 

Added line #L332 was not covered by tests

Check warning on line 338 in modyn/supervisor/internal/triggers/datadrifttrigger.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/datadrifttrigger.py#L337-L338 

Added lines #L337 - L338 were not covered by tests

Check warning on line 387 in modyn/supervisor/internal/triggers/datadrifttrigger.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/datadrifttrigger.py#L387 

Added line #L387 was not covered by tests

Check warning on line 402 in modyn/supervisor/internal/triggers/datadrifttrigger.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/datadrifttrigger.py#L402 

Added line #L402 was not covered by tests

Check warning on line 39 in modyn/supervisor/internal/triggers/drift/detection_window/amount.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/drift/detection_window/amount.py#L39 

Added line #L39 was not covered by tests

Check warning on line 58 in modyn/supervisor/internal/triggers/drift/detection_window/amount.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/drift/detection_window/amount.py#L57-L58 

Added lines #L57 - L58 were not covered by tests

Check warning on line 23 in modyn/supervisor/internal/triggers/drift/detection_window/time_.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/drift/detection_window/time_.py#L23 

Added line #L23 was not covered by tests

Check warning on line 34 in modyn/supervisor/internal/triggers/drift/detection_window/time_.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/drift/detection_window/time_.py#L33-L34 

Added lines #L33 - L34 were not covered by tests

Check warning on line 36 in modyn/supervisor/internal/triggers/drift/detection_window/time_.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/drift/detection_window/time_.py#L36 

Added line #L36 was not covered by tests

Check warning on line 40 in modyn/supervisor/internal/triggers/drift/detection_window/time_.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/drift/detection_window/time_.py#L39-L40 

Added lines #L39 - L40 were not covered by tests

Check warning on line 53 in modyn/supervisor/internal/triggers/drift/detection_window/time_.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/drift/detection_window/time_.py#L53 

Added line #L53 was not covered by tests

Check warning on line 56 in modyn/supervisor/internal/triggers/drift/detection_window/time_.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/drift/detection_window/time_.py#L55-L56 

Added lines #L55 - L56 were not covered by tests

Check warning on line 61 in modyn/supervisor/internal/triggers/drift/detection_window/time_.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/drift/detection_window/time_.py#L60-L61 

Added lines #L60 - L61 were not covered by tests

Check warning on line 65 in modyn/supervisor/internal/triggers/drift/detection_window/time_.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/drift/detection_window/time_.py#L64-L65 

Added lines #L64 - L65 were not covered by tests

Check warning on line 69 in modyn/supervisor/internal/triggers/drift/detection_window/time_.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/drift/detection_window/time_.py#L68-L69 

Added lines #L68 - L69 were not covered by tests

Check warning on line 73 in modyn/supervisor/internal/triggers/drift/detection_window/time_.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/drift/detection_window/time_.py#L71-L73 

Added lines #L71 - L73 were not covered by tests

Check warning on line 62 in modyn/supervisor/internal/triggers/drift/detector/alibi.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/drift/detector/alibi.py#L62 

Added line #L62 was not covered by tests

Check warning on line 51 in modyn/supervisor/internal/triggers/utils/utils.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

modyn/supervisor/internal/triggers/utils/utils.py#L51 

Added line #L51 was not covered by tests
View more details on Codecov