Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail explicitly in storage when asking for duplicate keys #530

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

MaxiBoether
Copy link
Contributor

When debugging #529 I realized this is a silent problem (we might access memory of a vector that is not allocated), so we should just explicitly fail.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.43%. Comparing base (c52a3d6) to head (e801778).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #530   +/-   ##
=======================================
  Coverage   82.43%   82.43%           
=======================================
  Files         214      214           
  Lines       10039    10039           
=======================================
  Hits         8276     8276           
  Misses       1763     1763           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@MaxiBoether MaxiBoether merged commit 84dac1d into main Jun 19, 2024
26 checks passed
@MaxiBoether MaxiBoether deleted the fix/MaxiBoether/morestoragefun branch June 19, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants