Fix replacement option in loss and gradnorm downsampling #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
==========================================
- Coverage 82.43% 82.43% -0.01%
==========================================
Files 214 214
Lines 10039 10038 -1
==========================================
- Hits 8276 8275 -1
Misses 1763 1763 ☔ View full report in Codecov by Sentry. |
XianzheMa
approved these changes
Jun 19, 2024
| @@ -50,8 +50,6 @@ def __init__( | |||
| assert "downsampling_ratio" in params_from_selector | |||
| self.downsampling_ratio = params_from_selector["downsampling_ratio"] | |||
|
|
|||
| self.replacement = params_from_selector.get("replacement", True) | |||
|
|
|||
There was a problem hiding this comment.
sorry I have noticed this issue since a month ago then forgot to correct it :( otherwise everything has gone smoother
|
let's just merge this I don't think any problem will be caused |
|
|
MaxiBoether
added a commit
that referenced
this pull request
Jun 19, 2024
When debugging #529 I realized this is a silent problem (we might access memory of a vector that is not allocated), so we should just explicitly fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an unused replacement option which defaulted to True, which caused multiple keys to be chosen, which caused the storage to crash since it cannot deal with multiple keys in its current implementation. However, it should not have happened in the first place.