p2p/nat: skip TestUPNP in non-CI envs if discover fails #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziogaschr
approved these changes
May 14, 2021
|
I just added the |
|
No word from EF yet. Going ahead with merge. |
Base automatically changed from
merge/foundation-release/1.10.3
to
release/1.12-rc1
May 24, 2021 19:05
|
SGTM |
ethereum/go-ethereum#21476 Date: 2021-05-13 12:33:01-05:00 Signed-off-by: meows <b5c6@protonmail.com>
meowsbits
force-pushed
the
merge/foundation-release/1.10.3-upnp-test
branch
from
9448508
to
12abdf4
Compare
|
Just rebased on the base branch to give the CIs a second chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethereum/go-ethereum#21476
Date: 2021-05-13 12:33:01-05:00
Signed-off-by: meows b5c6@protonmail.com