Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make test failed - TestUPNP_DDWRT #21476

Closed
zeoio opened this issue Aug 24, 2020 · 1 comment
Closed

make test failed - TestUPNP_DDWRT #21476

zeoio opened this issue Aug 24, 2020 · 1 comment
Labels
status:triage

Comments

@zeoio
Copy link
Contributor

zeoio commented Aug 24, 2020

enter make test, error message:

--- FAIL: TestUPNP_DDWRT (2.10s)
    natupnp_test.go:165: not discovered
@fjl
Copy link
Contributor

fjl commented Sep 22, 2020

Sorry, this is a known issue with this test. We can't really fix it because of a limitation with the underlying UPNP library.

@fjl fjl closed this as completed Sep 22, 2020
meowsbits added a commit to etclabscore/core-geth that referenced this issue May 13, 2021
@meowsbits
p2p/nat: skip TestUPNP in non-CI envs if discover fails
9448508 
ethereum/go-ethereum#21476

Date: 2021-05-13 12:33:01-05:00
Signed-off-by: meows <b5c6@protonmail.com>
@meowsbits meowsbits mentioned this issue May 13, 2021
Merged
meowsbits added a commit to etclabscore/ethereum.go-ethereum that referenced this issue May 13, 2021
@meowsbits
p2p/nat: skip TestUPNP in non-CI envs if discover fails
d82d5d9 
ethereum#21476

Date: 2021-05-13 12:33:01-05:00
Signed-off-by: meows <b5c6@protonmail.com>
@meowsbits meowsbits mentioned this issue May 13, 2021
Merged
meowsbits added a commit to etclabscore/core-geth that referenced this issue May 25, 2021
@meowsbits
p2p/nat: skip TestUPNP in non-CI envs if discover fails
12abdf4 
ethereum/go-ethereum#21476

Date: 2021-05-13 12:33:01-05:00
Signed-off-by: meows <b5c6@protonmail.com>
fjl pushed a commit that referenced this issue May 25, 2021
@meowsbits
p2p/nat: skip TestUPNP in non-CI environments if discover fails (#22877)
750115f 
Fixes #21476
meowsbits added a commit to etclabscore/core-geth that referenced this issue May 27, 2021
@meowsbits
p2p/nat: skip TestUPNP in non-CI envs if discover fails
a31540f 
ethereum/go-ethereum#21476

Date: 2021-05-13 12:33:01-05:00
Signed-off-by: meows <b5c6@protonmail.com>
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this issue Oct 15, 2021
@meowsbits @atif-konasl
p2p/nat: skip TestUPNP in non-CI environments if discover fails (ethe…
1cc8ea5 
…reum#22877)

Fixes ethereum#21476
@antonydenyer antonydenyer mentioned this issue Mar 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fjl @adamschmideg @zeoio