Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/common, tests/integration: Address tests var-naming lint rule #17635

Merged
merged 2 commits into from
Mar 24, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Mar 21, 2024

Addresses the var-naming issues in tests/common and tests/integration.

All of these changes were just in local variable names or unexported functions.

Part of #17578

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc ivanvc mentioned this pull request Mar 21, 2024
20 tasks
@ivanvc ivanvc force-pushed the address-tests-var-naming-lint-rule branch from be1ee4d to 4898908 Compare March 22, 2024 06:26
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ivanvc

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks

@ahrtr ahrtr merged commit 1348062 into etcd-io:main Mar 24, 2024
71 checks passed
@ivanvc ivanvc deleted the address-tests-var-naming-lint-rule branch August 16, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants