Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address var-name linter warnings #17578

Closed
20 tasks done
ivanvc opened this issue Mar 12, 2024 · 1 comment · Fixed by #17921
Closed
20 tasks done

Address var-name linter warnings #17578

ivanvc opened this issue Mar 12, 2024 · 1 comment · Fixed by #17921
Assignees
Labels
area/testing priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/cleanup

Comments

@ivanvc
Copy link
Member

ivanvc commented Mar 12, 2024

What would you like to be added?

As discussed at the March 7th etcd's community meeting, enabling the var-name revive linter involves about 1,000 lines of changes. To break this down into smaller subtasks, this would be small enough to be reviewable in pull requests while keeping the codebase functional.

Why is this needed?

To improve the quality of the code.

@jmhbnz jmhbnz added area/testing priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Mar 12, 2024
@ivanvc ivanvc self-assigned this Mar 21, 2024
@serathius
Copy link
Member

Thanks @ivanvc for your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/cleanup
Development

Successfully merging a pull request may close this issue.

3 participants