Address var-name linter warnings #17578
Labels
area/testing
priority/important-longterm
Important over the long term, but may not be staffed and/or may need multiple releases to complete.
type/cleanup
What would you like to be added?
As discussed at the March 7th etcd's community meeting, enabling the
var-name
revive linter involves about 1,000 lines of changes. To break this down into smaller subtasks, this would be small enough to be reviewable in pull requests while keeping the codebase functional.client/
directory - client: address golangci var-naming issues #17582api/
directory - Two public exported variables that need to be changed (ErrGRPCClusterIdMismatch
andErrClusterIDMismatch
). Does it make sense to deprecate the variables? Or, given that it's themain
branch, is it ok to rename them? - api: address golangci var-naming issues #17585pkg/
directory - pkg: address golangci var-naming issues #17584server/
directory - This contains about 500 instances that need to be changedserver/etcdserver
- etcdserver: address var naming lint rule #17614server/storage
- server/storage: address golangci var-naming issues #17660server/config
- server/config: address golangci var-naming issues #17854server/embed
server/*
- server: address golangci var-naming issues #17624tests/
directory - This contains about 350 instances that need to be changedtests/common
,tests/integration
- tests/common, tests/integration: Address tests var-naming lint rule #17635tests/e2e
- tests/e2e: address golangci var-naming issues #17636tests/framework
- tests/framework: address golangci var-naming issues #17651(*Member) GRPCURL()
tests/framework: address golangci var-naming issues [remove (*Member) GRPCURL()] #17655tests/robustness
- tests/robustness: address golangci var-naming issues #17654etcdutl/
,tools/
,tests/common/
- Address remaining var naming linter warnings #17863tools/.golangci.yaml
- Enable var-naming linter rule #17921Why is this needed?
To improve the quality of the code.
The text was updated successfully, but these errors were encountered: