etcdserver: address var naming lint rule #17614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
20 tasks
ivanvc
commented
Mar 19, 2024
Comment on lines
+790
to
+792
| //revive:disable:var-naming | ||
| func (s *store) JsonStats() []byte { | ||
| //revive:enable:var-naming |
There was a problem hiding this comment.
I decided to ignore this warning, as it is part of the v2 API, which I believe will be deprecated for v3.6.
serathius
approved these changes
Mar 19, 2024
ahrtr
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #17578.
Due to the number of changes required to update
(*EtcdServer) MemberIdtoMemberID, I decided to split this PR into two commits:server/etcdserver(*EtcdServer) MemberIdtoMemberIDI deprecated the two exported functions that I had to rename:
(*CheckRegistry)(*EtcdServer) MemberIdPlease read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.