api: address golangci var-naming issues #17585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
|
@ahrtr, let me know if I should deprecate the exported variables rather than renaming them as we agreed on |
YES, I think so |
Signed-off-by: Ivan Valdes <ivan@vald.es>
ivanvc
force-pushed
the
address-api-var-naming-lint-rule
branch
from
7ee064a
to
2190b0f
Compare
serathius
approved these changes
Mar 16, 2024
|
Nice, thanks for not breaking users and adding deprecations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the
var-naminglinter issues inapi.Renames the exported variables:
rpctypes.ErrGRPCClusterIdMismatch->rpctypes.ErrGRPCClusterIDMismatchrpctypes.ErrClusterIdMismatch->rpctypes.ErrClusterIDMismatchShould we need to deprecate rather than rename, I can add a linter exception.
Part of #17578.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.