Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable lint var name. #17306

Closed
wants to merge 1 commit into from

Conversation

liangyuanpeng
Copy link
Contributor

@k8s-ci-robot
Copy link

Hi @liangyuanpeng. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ivanvc
Copy link
Member

ivanvc commented Mar 13, 2024

Hi @liangyuanpeng, I see that you started working on addressing the warnings from this linter. However, the work required is rather large (I have addressed all of them, but after discussing this with the team on March 7th's community meeting, they decided to split addressing this into subtasks, which I'm already doing) and tracked in #17578.

However, would you be interested in working on enabling unexported-return?

@liangyuanpeng
Copy link
Contributor Author

@ivanvc I'm not focusing on that right now, thank you for working on this and explain it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants