-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit a timeout in testing robustness validation #16764
Conversation
f23e34a
to
e71ac09
Compare
cc @ahrtr |
e71ac09
to
69ded37
Compare
ping @ahrtr |
a quick question before I take a closer look, why add so many json files into the repo? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
Sorry for forgetting about this PR and your question.
Those are report files from robustness tests, that I added to the repo for testing. They are used to ensure there is no breaking change nor performance regression on robustness testing. There is a testdata directory that you can just add a robustness report from CI and a test will run robustness validation on it. It's pretty useful to allow reproduction of bugs in robustness test framework. |
ping @ahrtr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Please rebase this PR before merging. Previously I ran into a couple of cases which github did not identify the conflict.
69ded37
to
0f0e90f
Compare
Done |
/retest |
382a132
to
5b6db42
Compare
It will be more tricky than anticipated :( |
/retest |
477546f
to
e97d96a
Compare
Ok, I run into a problem with creating a cpu bound test that will execute in CI in a predictable time. Will remove adding the scenario for now. |
e97d96a
to
7ebd4ba
Compare
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
7ebd4ba
to
e2bb8c6
Compare
As part of #15598 I was working on re-implementing the history patching to avoid too much space explosion. One thing I noticed that it's not easy to reproduce linearization timeout if patching is totally disabled.
To ensure that patching is working and helping reduce the runtime, I have generated and added a case to
TestValidation
that is expected to run over 5 minutes without any patchingPlease read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.