Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robustness wal #16761

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Robustness wal #16761

merged 1 commit into from
Apr 14, 2024

Conversation

serathius
Copy link
Member

@serathius serathius commented Oct 15, 2023 •
edited
Loading

Ref #15598

@serathius serathius force-pushed the robustness-wal branch 3 times, most recently from 5f45b66 to 1e1a281 Compare October 16, 2023 13:00
@serathius serathius force-pushed the robustness-wal branch 3 times, most recently from e55f433 to fcf4d42 Compare January 25, 2024 16:07
@serathius serathius force-pushed the robustness-wal branch 5 times, most recently from bd5647d to 0fa800a Compare March 25, 2024 20:38
@serathius serathius force-pushed the robustness-wal branch 2 times, most recently from e770230 to a7f0ed2 Compare April 7, 2024 10:42
@serathius serathius marked this pull request as ready for review April 7, 2024 11:04
@serathius
Copy link
Member Author

cc @MadhavJivrajani @ahrtr @siyuanfoundation
This is ready for review.

@serathius
Copy link
Member Author

Prioritizing this as it is required for #17680

@serathius serathius mentioned this pull request Apr 7, 2024
Merged
@serathius serathius force-pushed the robustness-wal branch 4 times, most recently from 86dc8a6 to 44f6687 Compare April 8, 2024 07:14
MadhavJivrajani
MadhavJivrajani reviewed Apr 8, 2024
View reviewed changes
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Did a preliminary pass, I think I need to do another pass to fully understand the patching operation changes, will do it later today/tomorrow 👍🏼

tests/robustness/main_test.go Outdated Show resolved Hide resolved
tests/robustness/main_test.go Show resolved Hide resolved
tests/robustness/report/wal.go Show resolved Hide resolved
tests/robustness/report/wal.go Outdated Show resolved Hide resolved
tests/robustness/validate/validate_test.go Outdated Show resolved Hide resolved
siyuanfoundation
siyuanfoundation reviewed Apr 8, 2024
View reviewed changes
tests/robustness/report/wal.go Outdated Show resolved Hide resolved
tests/robustness/report/wal.go Show resolved Hide resolved
tests/robustness/validate/patch_history.go Outdated Show resolved Hide resolved
tests/robustness/validate/patch_history.go Outdated Show resolved Hide resolved
@serathius serathius force-pushed the robustness-wal branch 2 times, most recently from 79fb4fe to c56c959 Compare April 9, 2024 10:28
@siyuanfoundation
Copy link
Contributor

/lgtm

@serathius
Copy link
Member Author

ping @MadhavJivrajani @ahrtr

@MadhavJivrajani
Copy link
Contributor

MadhavJivrajani commented Apr 13, 2024 •
edited
Loading

LGTM
Thank you!

fuweid
fuweid approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serathius
Utilize WAL to patch operation history
569693b 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius serathius merged commit a7f5d4b into etcd-io:main Apr 14, 2024
43 of 44 checks passed
serathius added a commit to serathius/etcd that referenced this pull request Apr 14, 2024
@serathius
Merge pull request etcd-io#16761 from serathius/robustness-wal
3f20c2a 
Robustness wal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadhavJivrajani MadhavJivrajani MadhavJivrajani left review comments

@siyuanfoundation siyuanfoundation siyuanfoundation left review comments

@fuweid fuweid fuweid approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serathius @siyuanfoundation @MadhavJivrajani @fuweid @k8s-ci-robot