Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to grpc-1.47 (and fix the connection-string format) #14125

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Update to grpc-1.47 (and fix the connection-string format) #14125

merged 2 commits into from
Jun 17, 2022

Conversation

ptabor
Copy link
Contributor

@ptabor ptabor commented Jun 16, 2022 •
edited
Loading

Minimal change required to upgrade to grpc-1.47.

#14112. Connecting to unix:localhost:port instead of never officially supported unix://localhost:port (https://grpc.github.io/grpc/cpp/md_doc_naming.html)

ahrtr
ahrtr reviewed Jun 16, 2022
View reviewed changes
api/go.mod
@@ -9,7 +9,7 @@ require (
github.com/grpc-ecosystem/grpc-gateway v1.16.0
github.com/stretchr/testify v1.7.0
google.golang.org/genproto v0.0.0-20211118181313-81c1377c94b1
google.golang.org/grpc v1.41.0
google.golang.org/grpc v1.47.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title mentions 1.48, but actually 1.47

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) I guess it's a typo in the PR title as the latest stable release is 1.47. lgmt.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Reworded.

@ptabor ptabor changed the title Update to grpc-1.48 (and fix the connection-string format) Update to grpc-1.47 (and fix the connection-string format) Jun 16, 2022
@ptabor ptabor mentioned this pull request Jun 16, 2022
Merged
@ahrtr
Copy link
Member

ahrtr commented Jun 17, 2022

@ptabor Overall the PR looks good to me. But I don't understand why do you add one more directory out, and get some go.mod and go.sum files included in it? I guess they might be just intermediate files generated during your debug?

@ptabor
Update grpc to 1.47 and go-cmp to 0.5.8.
17c1dcd 
Signed-off-by: Piotr Tabor <ptab@google.com>
@ptabor
Use proper grpc schema (unix:file) for unix sockets.
cbf54a0 
Signed-off-by: Piotr Tabor <ptab@google.com>
@ptabor
Copy link
Contributor Author

ptabor commented Jun 17, 2022

@ptabor Overall the PR looks good to me. But I don't understand why do you add one more directory out, and get some go.mod and go.sum files included in it? I guess they might be just intermediate files generated during your debug?

Removed it. It was produces by intelij. I've just added to it to .gitignore to avoid such problems... and it has happened.

ahrtr
ahrtr approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptabor ptabor merged commit 8ac23da into etcd-io:main Jun 17, 2022
@ptabor ptabor deleted the 20220615-update-grpc2 branch June 17, 2022 08:04
@ptabor ptabor mentioned this pull request Jun 17, 2022
Closed
@ahrtr ahrtr mentioned this pull request Jun 23, 2022
Closed
@chaochn47 chaochn47 mentioned this pull request Sep 18, 2023
Closed
chaochn47 added a commit to chaochn47/etcd that referenced this pull request Sep 20, 2023
@chaochn47
backport etcd-io#14125 to release-3.5: Update to grpc-1.47 (and fix t…
51bfc2f 
…he connection-string format)

Signed-off-by: Chao Chen <chaochn@amazon.com>
@chaochn47 chaochn47 mentioned this pull request Sep 20, 2023
Merged
chaochn47 added a commit to chaochn47/etcd that referenced this pull request Oct 12, 2023
@chaochn47
backport etcd-io#14125 to release-3.5: Update to grpc-1.47 (and fix t…
92c4df7 
…he connection-string format)

Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47 added a commit to chaochn47/etcd that referenced this pull request Oct 12, 2023
@chaochn47
backport etcd-io#14125 to release-3.5: Update to grpc-1.47 (and fix t…
568c9d6 
…he connection-string format)

Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47 added a commit to chaochn47/etcd that referenced this pull request Oct 12, 2023
@chaochn47
backport etcd-io#14125 to release-3.5: Update to grpc-1.47 (and fix t…
db16069 
…he connection-string format)

Signed-off-by: Chao Chen <chaochn@amazon.com>
@jmhbnz jmhbnz mentioned this pull request Aug 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spzala spzala spzala left review comments

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
stage/merge-when-tests-green
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptabor @ahrtr @spzala