Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GRPC url standard #14112

Closed
serathius opened this issue Jun 14, 2022 · 3 comments
Closed

Use GRPC url standard #14112

serathius opened this issue Jun 14, 2022 · 3 comments
Labels
area/testing help wanted priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. stage/tracked
Milestone

Comments

@serathius
Copy link
Member

Etcd code and tests depend on In particular our tests depend a lot on unix://localhost:port url schema, while
according to grpc standard: https://grpc.github.io/grpc/cpp/md_doc_naming.html the supported names are: unix:path or unix://absolute_path (so unix:///tmp/foo). This issue blocks grpc upgrade as etcd tests will not pass until we stop using unix://localhost:port.

Context #14104

First issue that we need to address is stop depending on unix://localhost:port schema in tests to unblock dependency upgrade. Later we should propose a plan to match grpc standard. I expect this might require multiple releases to avoid introducing breaking changes.

@serathius serathius added area/testing help wanted priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. stage/tracked labels Jun 14, 2022
@serathius serathius added this to the etcd-v3.6 milestone Jun 14, 2022
@serathius
Copy link
Member Author

@ptabor Thanks for fixing the connection format, any followups needed or we can close the issue?

@serathius
Copy link
Member Author

ping

@ptabor
Copy link
Contributor

ptabor commented Mar 18, 2023

It's good enough for now. I don't think we have cycles to review all URL schemes proactively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing help wanted priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. stage/tracked
Development

No branches or pull requests

2 participants