Conversation
quaxsze
approved these changes
Mar 3, 2020
AntoineAugusti
approved these changes
Mar 3, 2020
Member
|
I can take a look at the XLS type tester if you want too, but it's not a priority, I agree. I'd need example files and a quick note about what's going on |
Closed
Contributor
Author
|
@AntoineAugusti cf #61. I you have time to take a look it would be great, in the meantime I won't merge this. |
Member
|
The type tester is now fixed for XLS files. Fixes #61 |
AntoineAugusti
changed the title
Contributor
Author
|
@AntoineAugusti you're the best ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61
The type tester from #42 seems to break on real world xls files. I don't want to spend too much time on XLS support, so I just removed it for XLS files. Also added XLS examples in tests.