Parse hours, SIREN and SIRET as text#42
Merged
AntoineAugusti merged 8 commits intomasterfrom Sep 4, 2019
Merged
Conversation
Member
Author
|
|
Contributor
|
Cool! This means we can write a SIREN/SIRET detector and stop parsing them as integer 💪 |
Member
Author
|
Yup, but it requires patching agatesql as well. For now it doesn't seem possible to append a custom type to the type => SQL type mapping defined. What's the problem with SIREN or SIRET parsed as integers? |
Contributor
|
Leading 0 |
Contributor
|
I guess we can fork agate-sql and make a PR upstream to account for custom types. |
AntoineAugusti
changed the title
AntoineAugusti
force-pushed
the
parse-time
branch
from
13316ce to
d9341b2
Compare
AntoineAugusti
commented
Sep 4, 2019
abulte
reviewed
Sep 4, 2019
abulte
reviewed
Sep 4, 2019
abulte
approved these changes
Sep 4, 2019
Member
Author
|
@abulte Should I merge this as it is? Should I add things to the CHANGELOG / change other files? |
Contributor
|
@AntoineAugusti Add a line in CHANGELOG and then LGTM |
Member
Author
|
|
This was referenced Mar 3, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #41.
Detect values that should be treated as strings and force a string casting. This PR introduces a custom type checker for
agateto recognise hours, SIREN and SIRET.