-
-
Notifications
You must be signed in to change notification settings - Fork 791
feat(es_extended): add Vehicle Identification Number (VIN) system #1707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gtolontop
wants to merge
15
commits into
esx-framework:dev
Choose a base branch
from
gtolontop:feat/vehicle-vin-system
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icle properties from owned_vehicles table
…tate and data object
…vehicle identification
…r vehicles without one
…ehicle VIN by plate
… to find vehicles by VIN
…ehicle VIN by plate
… format and uniqueness check
…erve model names in VIN generation (server/classes/vehicle)
…ARCHAR(17) constraint
…X types (remove car/truck/helicopter, add quadbike/amphibious/trailer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a complete Vehicle Identification Number (VIN) system for ESX vehicles, as requested in issue #1638. Each vehicle now has a unique 17-character VIN that persists across plate changes and provides a permanent identifier for vehicles.
Motivation
Currently, vehicles are only identified by their license plate, which creates limitations for advanced roleplay mechanics. A VIN system enables:
Implementation Details
vin
column (VARCHAR(17) UNIQUE) toowned_vehicles
table with indexvin
field toCVehicleData
getVin()
method to retrieve VINESX.GenerateVIN()
- Generates unique VIN with database collision checkESX.GetExtendedVehicleFromVIN(vin)
- Find vehicle by VIN/getvehiclevin [plate]
for testing and debuggingUsage Example
Admin command usage:
/getvehiclevin ABC123
Shows notification: Vehicle VIN:
g1ES1234567890ABCDsPR Checklist