This is a major thing as it will definitely break the current API. We thus should consider this as a move towards Release 1.0.
During my efforts moving the tests to Catch2 I stumbled upon this problem on Windows. And indeed, it is rather stupid that we defined the enumerations as all caps as this is somehow the defacto standard for preprocessor definitions.
The C++ core guideslines use a lower case notation for the enumerations. This might cause problems too in some cases but only when we would like to use keywords as enumerations (like true and false in EBool). In general this would be the better choice and thus we should do this rather early than latter.
DOD:
- all enumerations use lower-case names
This is a major thing as it will definitely break the current API. We thus should consider this as a move towards Release 1.0.
During my efforts moving the tests to Catch2 I stumbled upon this problem on Windows. And indeed, it is rather stupid that we defined the enumerations as all caps as this is somehow the defacto standard for preprocessor definitions.
The C++ core guideslines use a lower case notation for the enumerations. This might cause problems too in some cases but only when we would like to use keywords as enumerations (like
trueandfalseinEBool). In general this would be the better choice and thus we should do this rather early than latter.DOD: