-
Couldn't load subscription status.
- Fork 173
feat(websocket): support per-message compression (RFC7692) (IDFGH-16651) #916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
I guess I will change this to a draft PR first until the parent PR espressif/esp-idf#17746 is merged to ESP-IDF. |
1f2478c to
fc8c58e
Compare
|
@huming2207 Before proceeding, I wanted to point out that libwebsockets, which is already integrated into esp-protocols, natively supports per-message compression (RFC 7692). A few questions to help evaluate the best approach:
Best regards, |
|
Hi @gabsuren Thanks for your reply. The major reason for why we are not using
I know you may ask what if later we somehow don't want to use Espressif chips any more. If that's the case then indeed we can't use Regards, |
|
@gabsuren As you guys stated in the libwebsocket README:
It's just too much. It won't even run on ESP8684. 😅 I also remember back in 2018 this thing will blow up the stack easily. Therefore from our impression this thing isn't designed for small embedded systems. |
Description
This PR is for add the support for per-message compression (deflate) for websocket client.
Please note that this PR is depends on its parent PR in ESP-IDF: espressif/esp-idf#17746
Related
See:
Testing
I will test with a Node.js and/or Bun.js server and see if it actually works or not.
Checklist
Before submitting a Pull Request, please ensure the following: