- 
                Notifications
    You must be signed in to change notification settings 
- Fork 7.9k
feat(transport_ws): add support for per-message compression (RFC7692) handshakes (IDFGH-16647) #17746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| 
 👋 Hello huming2207, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
 Review and merge process you can expect ...
 | 
4f16476    to
    9d2eef5      
    Compare
  
    9d2eef5    to
    57ee5c9      
    Compare
  
    57ee5c9    to
    506487f      
    Compare
  
    506487f    to
    10e5b93      
    Compare
  
    
Description
Hi all,
This is to implement the feature request issue mentioned in espressif/esp-protocols#912
This is the first part of supporting RFC7692, where it only does the handshake. Since ESP-IDF doesn't have zlib dependency and I prefer not to add it in (because it's huge), while miniz doesn't support adjusting window bit, so the actual compression needs to be done in the websocket clients. I will draft another PR to esp-protocols/esp-websocket-client to support the compression soon.
See the original feature request for further details.
Related
See espressif/esp-protocols#912
Checklist
Before submitting a Pull Request, please ensure the following: