Add missing sntp_init/sntp_stop #7628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisonja
added a commit
to davisonja/Arduino
that referenced
this pull request
Oct 16, 2020
* master: (37 commits) BREAKING: Change return EEPROM.end() to bool (esp8266#7630) BREAKING: Change return type of channel() (esp8266#7656) BREAKING: Change return type of RSSI() (esp8266#7657) Add Copyright notice to Schedule.h (esp8266#7653) MDNS MultiInterface (esp8266#7636) BREAKING: Add Wrong Password wifi status case (esp8266#7652) New flash writing method with offset/memory/size alignment handling (esp8266#7514) Fix error when debug enabled but no port chosen (esp8266#7648) LEAmDNSv2: change a macro name to be independant from LEAmDNS1 (esp8266#7640) Allow test framework to use cores/esp8266/Arduino.h directly (esp8266#7377) Update OTA HTTP Server Header Information (esp8266#7633) Add missing sntp_init/sntp_stop (esp8266#7628) Use direct member initialization instead of ctr initialisation (esp8266#7558) Prevent rewriting Updater_Signing.h if content unchanged (esp8266#7627) Add WiFi Multi to readme.rst Remove stray axtls refs, deprecated compat funcs (esp8266#7626) Pull deprecated axtls link (esp8266#7624) Redesign ESP8266WiFiMulti.[cpp|h] Update README.md (esp8266#7623) Eliminate code duplication by template for printNumber(...)/printFloat(...). ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #7109,
sntp_stopandsntp_initare not called anymore when usingconfigTime(int timezone_sec, int daylightOffset_sec, const char* server1, const char* server2, const char* server3)This results in NTP sync not working. (
settimeofday_cbcallback is never called).