simple TZ api: bypass sprintf/sscanf: + 7KB #7109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devyte
requested changes
Feb 25, 2020
earlephilhower
approved these changes
Feb 25, 2020
There was a problem hiding this comment.
Great way to save code for those left with 512KB flash!, while preserving the use of library code.
Other than the #if comment from @devyte, LGTM.
|
@d-a-v Thx!, The PR eliminates the firmware size increase. :-) |
|
I was asking about OTA because I have been thinking that increased size on one side would be compensated by size decrease on the other (thanks to compressed OTA). But as @earlephilhower noted, there are still 512K flash chips around, these ones could use any flash size optimization. |
This was referenced Jun 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7107
@Jason2866 do you confirm tasmota fits in its previous size ?
About that, are you using compressed OTA ?