Skip to content

Fix warnings and clean up a RTC driver #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2023
Merged

Fix warnings and clean up a RTC driver #440

merged 1 commit into from
Mar 14, 2023

Conversation

JurajSadel
Copy link
Contributor

Removes unused C6's enable_8m(), which is used in estimate_xtal_frequency() and we don't have it for C6 yet.
Removes a bunch of duplicated C6-related functions.

closes #437

bjoernQ
bjoernQ approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We can re-add the functions once we choose to implement the functionality that will use it.

Probably we also need some more refactoring for the whole module in future - e.g. seems that RtcCalInternalOsc is also not available on ESP32-C2

@jessebraham jessebraham merged commit ec6220f into esp-rs:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Compiler Warnings introduced by ESP32-C6 Support
4 participants
@JurajSadel @bjoernQ @MabezDev @jessebraham