Skip to content

Clock monitor HIL test #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Apr 12, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • My changes were added to the CHANGELOG.md in the proper section.

Extra:

Pull Request Details 📖

Description

Adds an HIL test for verifying the estimated clock freq. Not sure how useful this test is, tbh.

Testing

Tested locally on S3, C6 and H2.

Manually triggered the HIL workflow: https://github.com/esp-rs/esp-hal/actions/runs/8659761291

@SergioGasquez SergioGasquez force-pushed the feat/hil-clock-monitor branch from 9f8970c to 69d3265 Compare April 12, 2024 08:18
@SergioGasquez SergioGasquez added the skip-changelog No changelog modification needed label Apr 12, 2024
@SergioGasquez SergioGasquez marked this pull request as draft April 12, 2024 08:29
@SergioGasquez SergioGasquez force-pushed the feat/hil-clock-monitor branch 4 times, most recently from 768eceb to 41f3bdc Compare April 12, 2024 09:12
@SergioGasquez SergioGasquez marked this pull request as ready for review April 12, 2024 09:18
@SergioGasquez SergioGasquez force-pushed the feat/hil-clock-monitor branch 4 times, most recently from 76d16e2 to 7f59785 Compare April 12, 2024 10:08
@jessebraham
Copy link
Member

Thanks for the contribution, and sorry to ask this, but does it really make sense to test this? The clock monitor isn't even close to accurate to begin with, and I also don't really see what we gain by testing it.

@SergioGasquez
Copy link
Member Author

SergioGasquez commented Apr 12, 2024

but does it really make sense to test this?

Not really sure, tbh. I am happy to close the PR if we think its not worth

@MabezDev
Copy link
Member

Thanks for the contribution, and sorry to ask this, but does it really make sense to test this? The clock monitor isn't even close to accurate to begin with, and I also don't really see what we gain by testing it.

I would say yes in this case, be cause we actually use it internally (that's how we removed the xtal features), if this silently starts being wrong we'll have some fun debugging :D.

@SergioGasquez SergioGasquez force-pushed the feat/hil-clock-monitor branch from 61cf62d to bf9272f Compare April 15, 2024 08:58
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides what Clippy says this looks good to me

@SergioGasquez SergioGasquez force-pushed the feat/hil-clock-monitor branch from bf9272f to bc9c594 Compare April 15, 2024 09:23
@SergioGasquez SergioGasquez force-pushed the feat/hil-clock-monitor branch from 9bfc37f to a8f528c Compare April 15, 2024 09:27
@SergioGasquez SergioGasquez requested a review from MabezDev April 15, 2024 09:28
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just needs a rebase.

@SergioGasquez SergioGasquez force-pushed the feat/hil-clock-monitor branch from a8f528c to 6fa84c1 Compare April 15, 2024 09:45
@SergioGasquez SergioGasquez added this pull request to the merge queue Apr 15, 2024
Merged via the queue into esp-rs:main with commit 381ce95 Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants