-
Notifications
You must be signed in to change notification settings - Fork 313
Clock monitor HIL test #1425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clock monitor HIL test #1425
Conversation
9f8970c
to
69d3265
Compare
768eceb
to
41f3bdc
Compare
76d16e2
to
7f59785
Compare
Thanks for the contribution, and sorry to ask this, but does it really make sense to test this? The clock monitor isn't even close to accurate to begin with, and I also don't really see what we gain by testing it. |
Not really sure, tbh. I am happy to close the PR if we think its not worth |
I would say yes in this case, be cause we actually use it internally (that's how we removed the xtal features), if this silently starts being wrong we'll have some fun debugging :D. |
61cf62d
to
bf9272f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
besides what Clippy says this looks good to me
bf9272f
to
bc9c594
Compare
9bfc37f
to
a8f528c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Just needs a rebase.
a8f528c
to
6fa84c1
Compare
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
Adds an HIL test for verifying the estimated clock freq. Not sure how useful this test is, tbh.
Testing
Tested locally on S3, C6 and H2.
Manually triggered the HIL workflow: https://github.com/esp-rs/esp-hal/actions/runs/8659761291